test01_pkgquality: fix find command to avoid false positives

Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
This commit is contained in:
Davide Madrisan 2012-01-15 17:30:49 +01:00
parent 65e8d69c6b
commit 442af8b3b2
2 changed files with 8 additions and 1 deletions

View File

@ -51,6 +51,12 @@ Sun Jan 15 2012 Davide Madrisan <davide.madrisan(a)gmail.com>
Action 5: add a message asking developers to run quality and security Action 5: add a message asking developers to run quality and security
tests. tests.
+ bugfix
* tests/test01_pkgquality - Davide Madrisan:
Fix find command used when checking for wrong file attributes in bin and lib
directories, to avoid false positives (seen for files whose names include
the substring '.so', like 'net.sourceforge.kile.main.xml').
-------------------------------------------------------------------------------- --------------------------------------------------------------------------------
Changes in version 1.8.2 Changes in version 1.8.2

View File

@ -189,7 +189,8 @@ checking for wrong file attributes in bin and lib directories""${NORM}..."
for pck in ${rpmpkg_name[@]}; do for pck in ${rpmpkg_name[@]}; do
pushd $tmpextractdir/$i >/dev/null pushd $tmpextractdir/$i >/dev/null
for f in $( find . -type f \ for f in $( find . -type f \
\( -name '*.so*' -not -perm 755 \) -or \ \( -name '*.so.*' -not -perm 755 \) -or \
\( -name '*.so' -not -perm 755 \) -or \
\( \( -path './bin/*' -or \ \( \( -path './bin/*' -or \
-path './sbin/*' -or \ -path './sbin/*' -or \
-path './usr/bin/*' -or \ -path './usr/bin/*' -or \