From 442af8b3b215053a06ff240e1b4c3a46e83b4939 Mon Sep 17 00:00:00 2001 From: Davide Madrisan Date: Sun, 15 Jan 2012 17:30:49 +0100 Subject: [PATCH] test01_pkgquality: fix find command to avoid false positives Signed-off-by: Davide Madrisan --- ChangeLog | 6 ++++++ tests/test01_pkgquality.in | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e3f09fb..cfbd2fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -51,6 +51,12 @@ Sun Jan 15 2012 Davide Madrisan Action 5: add a message asking developers to run quality and security tests. ++ bugfix + * tests/test01_pkgquality - Davide Madrisan: + Fix find command used when checking for wrong file attributes in bin and lib + directories, to avoid false positives (seen for files whose names include + the substring '.so', like 'net.sourceforge.kile.main.xml'). + -------------------------------------------------------------------------------- Changes in version 1.8.2 diff --git a/tests/test01_pkgquality.in b/tests/test01_pkgquality.in index 7409466..847d571 100644 --- a/tests/test01_pkgquality.in +++ b/tests/test01_pkgquality.in @@ -189,7 +189,8 @@ checking for wrong file attributes in bin and lib directories""${NORM}..." for pck in ${rpmpkg_name[@]}; do pushd $tmpextractdir/$i >/dev/null for f in $( find . -type f \ - \( -name '*.so*' -not -perm 755 \) -or \ + \( -name '*.so.*' -not -perm 755 \) -or \ + \( -name '*.so' -not -perm 755 \) -or \ \( \( -path './bin/*' -or \ -path './sbin/*' -or \ -path './usr/bin/*' -or \