From 60535caa3b0afa860eaeb60770adff80d4210767 Mon Sep 17 00:00:00 2001
From: Davide Madrisan <davide.madrisan@gmail.com>
Date: Thu, 21 Feb 2013 21:30:24 +0100
Subject: [PATCH] ifup, ifdown: display an error message when executed without
 any argument

Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
---
 sbin/ifdown | 7 +++++--
 sbin/ifup   | 5 ++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/sbin/ifdown b/sbin/ifdown
index c9c0779..bafbde5 100644
--- a/sbin/ifdown
+++ b/sbin/ifdown
@@ -1,13 +1,16 @@
 #!/bin/bash
 # Copyright (c) 2003-2012 by Silvan Calarco <silvan.calarco@mambasoft.it>
-# Copyright (c) 2003-2009 by Davide Madrisan <davide.madrisan@gmail.com>
+# Copyright (c) 2003-2009,2013 by Davide Madrisan <davide.madrisan@gmail.com>
 
 . /etc/sysconfig/rc
 . $rc_functions
 
 DEVICE=${1}
 
-[ "${DEVICE}" ] || exit 1
+if [ -z "$DEVICE" ]; then
+   echo "Usage: ifdown <device name>" 1>&2
+   exit 1
+fi
 
 [ "$NM_CONTROLLED" = "0" ] || exit 0
 
diff --git a/sbin/ifup b/sbin/ifup
index c71a3b8..a1e9a6c 100644
--- a/sbin/ifup
+++ b/sbin/ifup
@@ -8,7 +8,10 @@
 
 DEVICE=${1}
 
-[ "${DEVICE}" ] || exit 1
+if [ -z "$DEVICE" ]; then
+   echo "Usage: ifup <device name>" 1>&2
+   exit 1
+fi
 
 [ -r /etc/sysconfig/network ] && . /etc/sysconfig/network
 [ -r $network_devices/ifcfg-${DEVICE} ] && . $network_devices/ifcfg-${DEVICE}