From b8a3d879d1536c3fe5cee433efa3d04271300878 Mon Sep 17 00:00:00 2001 From: Davide Madrisan Date: Sun, 15 Jan 2012 15:30:42 +0100 Subject: [PATCH] pck-update: add a msg asking developers to run quality and security test Signed-off-by: Davide Madrisan --- ChangeLog | 6 +++++- plugins/pck-update.in | 17 ++++++++++++----- po/it/pck-update.po | 5 ++++- 3 files changed, 21 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5e9a444..e3f09fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -43,10 +43,14 @@ Sun Jan 15 2012 Davide Madrisan New test: check for setgid directories. + update - tests/test01_pkgquality + * tests/test01_pkgquality tests/test02_pkgsecurity - Davide Madrisan: Rework coloring schema and make output a bit more compact. + * pck-update - Davide Madrisan: + Action 5: add a message asking developers to run quality and security + tests. + -------------------------------------------------------------------------------- Changes in version 1.8.2 diff --git a/plugins/pck-update.in b/plugins/pck-update.in index 03ba585..3798093 100644 --- a/plugins/pck-update.in +++ b/plugins/pck-update.in @@ -1,6 +1,6 @@ #!/bin/bash # pck-update -- plugin for @package@ -# Copyright (C) 2004-2011 Davide Madrisan +# Copyright (C) 2004-2012 Davide Madrisan [ -z "$BASH" ] || [ ${BASH_VERSION:0:1} -lt 3 ] && { echo $"this script requires bash version 3 or better" >&2 && exit 1; } @@ -2250,18 +2250,25 @@ specfile is newer than srpm (according to modification date)" # as the dependencies check is done before, it is safe to pass # --nodeps to non-simulated build commands. eval "\ -rpmbuild -bs $rpmbuild_opts --nodeps $SRPM_SPECFILE_WITH_PATH $USER_RPMDEFINE_OPTS 2>&1" +rpmbuild -bs $rpmbuild_opts --nodeps \ +$SRPM_SPECFILE_WITH_PATH $USER_RPMDEFINE_OPTS 2>&1" elif [ "$nosrpm" = 1 ]; then notify.note "${NOTE}"$"building the rpm packages""${NORM}..." eval "\ -rpmbuild -bb $rpmbuild_opts --nodeps $SRPM_SPECFILE_WITH_PATH $USER_RPMDEFINE_OPTS 2>&1" +rpmbuild -bb $rpmbuild_opts --nodeps \ +$SRPM_SPECFILE_WITH_PATH $USER_RPMDEFINE_OPTS 2>&1" else notify.note "${NOTE}"$"building rpm and srpm packages""${NORM}..." eval "\ -rpmbuild -ba $rpmbuild_opts --nodeps $SRPM_SPECFILE_WITH_PATH $USER_RPMDEFINE_OPTS 2>&1" +rpmbuild -ba $rpmbuild_opts --nodeps \ +$SRPM_SPECFILE_WITH_PATH $USER_RPMDEFINE_OPTS 2>&1" fi - [ $? -eq 0 ] || + if [ $? -eq 0 ]; then + notify.note "\n${NOTE}"$"\ +It seems good but do not forget to run quality and security tests.""${NORM}" + else notify.error $"rpmbuild exited with error code \`$?'" + fi ;; 6) notify.note "[${NOTE}step $step${NORM}] -- ${NOTE}"$"\ build the list of the build requirements""${NORM}" diff --git a/po/it/pck-update.po b/po/it/pck-update.po index a7626c0..3af7c95 100644 --- a/po/it/pck-update.po +++ b/po/it/pck-update.po @@ -1,5 +1,5 @@ # translation of it.po to Italiana -# Copyright (C) 2004-2008 Davide Madrisan +# Copyright (C) 2004-2008,2012 Davide Madrisan # Davide Madrisan msgid "" @@ -497,3 +497,6 @@ msgstr "rimozione dei pacchetti sorgente e delle patch, se presenti" msgid "removing" msgstr "rimozione di" + +msgid "It seems good but do not forget to run quality and security tests." +msgstr "Sembra ok ma non dimenticare di eseguire i test di qualità e sicurezza."